Conversation
Contributor
Author
|
@sandersn can i get a CR for this one? |
j-oliveras
reviewed
Dec 1, 2017
|
|
||
| autoArrayType = createArrayType(autoType); | ||
| if (autoArrayType === emptyObjectType) { | ||
| // autoArrayType is used as a marker, so even if global Array type is not defined, it needs ot be a unique type |
Contributor
There was a problem hiding this comment.
Typo at end of line: ot instead of to.
sandersn
approved these changes
Dec 1, 2017
Member
sandersn
left a comment
There was a problem hiding this comment.
Looks good except for the typo @j-oliveras pointed out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make sure that the type we use for
autoArrayTypeis unique even if no globalArraytype was providedFixes #20333