Disable import fix for method of 'export =' value#20208
Merged
4 commits merged intoNov 28, 2017
Merged
Conversation
mhegazy
reviewed
Nov 21, 2017
| if (exportSymbolWithIdenticalName && checkSymbolHasMeaning(exportSymbolWithIdenticalName, currentTokenMeaning)) { | ||
| if (exportSymbolWithIdenticalName && checkSymbolHasMeaning(exportSymbolWithIdenticalName, currentTokenMeaning) | ||
| // Don't auto-import a method of an `export =` module (See GH#20191) | ||
| && !(exportSymbolWithIdenticalName.flags & SymbolFlags.Method)) { |
Contributor
There was a problem hiding this comment.
this is going to break many of the dt definitions.. for instance, JQuery: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/jquery/index.d.ts#L28
Member
There was a problem hiding this comment.
Instead of just relying on the meaning, I think what's more correct is to check is if the symbol's declarations is part of the global Object, String, Number , or Symbol declaration, right? I think you could probably check using our current internal checker APIs by doing something like
exportSymbolWithIdenticalName.valueDeclaration && checker.getPropertyOfType(checker.getStringType(), exportSymbolWithIdenticalName.name).valueDeclaration === exportSymbolWithIdenticalName.valueDeclaration // repeat for number, symbol, object
Author
|
@weswigham @mhegazy Please re-review |
mhegazy
reviewed
Nov 28, 2017
|
|
||
| const type = getTypeOfSymbol(exportEquals); | ||
| // If the apparent type is different, this is a primitive, so let's not treat that as an exported symbol. | ||
| return getApparentType(type) === type ? getPropertyOfType(type, memberName) : undefined; |
Contributor
There was a problem hiding this comment.
why not just type && type.typeFlags & TypeFlags.Primitive ?
mhegazy
reviewed
Nov 28, 2017
| } | ||
|
|
||
| const type = getTypeOfSymbol(exportEquals); | ||
| // If the apparent type is different, this is a primitive, so let's not treat that as an exported symbol. |
mhegazy
approved these changes
Nov 28, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20191