You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
what is the rational for this change? we do have multiple array/list helper functions that are hand-rolled, like map, filter, foreach, etc.. so what is the guiding principal here?
I think we should be removing any shim function once we move to an ES version that supports it natively. That might include contains (Array.includes), stringContains (String.includes) and find one day. map and filter both handle undefined, which we use instead of empty arrays to reduce allocations; ideally we would use an immutable emptyArray for that (#16312), and then use builtin map and filter instead. forEach is ambiguous over 3 different meanings, and should be replaced with a for loop, some, or find.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't need this now that we're targeting ES5.