Move utilities for getting type parameter constraints and defaults from public lazy members to services#20162
Merged
Conversation
…om public lazy members to services
ghost
reviewed
Nov 21, 2017
| getSuggestionForNonexistentSymbol(location: Node, name: string, meaning: SymbolFlags): string | undefined; | ||
| /* @internal */ getBaseConstraintOfType(type: Type): Type | undefined; | ||
| getBaseConstraintOfType(type: Type): Type | undefined; | ||
| getDefaultFromTypeParameter(type: Type): Type | undefined; |
There was a problem hiding this comment.
Why not just take a TypeParameter as input?
Member
Author
There was a problem hiding this comment.
Just to be the same as getBaseConstraintOfType. Which, BTW, getBaseConstraintOfType technically returns the resolvedBaseConstraint, while getConstraintFromTypeParameter would actually return the constraint; the different being that getBaseConstraintOfType follows all the constraints on your constraints to get the actual final constraint, while getConstraintFromTypeParameter is just the immediate constraint. Should we be exposing both?
mhegazy
approved these changes
Nov 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20137