react starter needs node ref, accept fixed leveldown#19994
Merged
Conversation
mhegazy
approved these changes
Nov 14, 2017
Contributor
|
seems wrong that you need react.d.ts and node.d.ts in the same compilation.. does leveldown really needs node? |
Member
Author
|
@mhegazy not |
Contributor
|
for Just to be clear, the test as you have now is fine, i am just noting an issue with the starter kit. |
Member
|
Note to self: leveldown still failed for me until I deleted user/leveldown/node_modules. user tests might need to delete node_modules too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.