Bidirectional comparable relation for primitive types#19926
Merged
Conversation
sandersn
approved these changes
Nov 10, 2017
| @@ -0,0 +1,8 @@ | |||
| // @strict: true | |||
|
|
|||
| // Verify that properties can vary idependently in comparable relationship | |||
weswigham
approved these changes
Nov 10, 2017
Member
weswigham
left a comment
There was a problem hiding this comment.
Given how similar the logic in two replaced callsites for isSimpleTypeRelatedTo is, it'd be nice to see the logic moved into a helper function; but it's not required, since it's only duplicating code in two places. 🤷♂️
RyanCavanaugh
approved these changes
Nov 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the comparable relation bidirectional for primitive types. For example, the following previously was an error but is now permitted: