In forEachExternalModule, skip node_modules beginning with _.#19910
In forEachExternalModule, skip node_modules beginning with _.#19910ghost wants to merge 1 commit into
forEachExternalModule, skip node_modules beginning with _.#19910Conversation
29d6dd4 to
4ddc27b
Compare
4ddc27b to
e7d1095
Compare
Because our default behavior is to search for files which many contain global declarations, like |
|
this seems rather arbitrary solution.. there has to be a more structured/holistic approach to addressing this problem. i am not sure i understand the behavior of cnpm to be able to have an educated discussion, so i will need to readup and then we can talk. |
|
I think what matters is that there's junk in |
|
@andy the _rax included in the program is not because everything in node_modules is auto included.. That portion works well wherein when we get base file names for tsconfig.json we wouldnt include node_modules. The file when imports rax it includes the _raxXXXX thing because in the node_modules rax is npm link to that folder... And hence it shows up in the program files.. If you look at the tsserver project files, it wont have any other modules with |
|
Replaced by #20395 |
Fixes #19893
This is probably not the right solution -- why are we including everything in
node_moduleseven when they were never imported before?