For import completion of default import, convert module name to identifier#19875
Merged
2 commits merged intoNov 9, 2017
Merged
For import completion of default import, convert module name to identifier#198752 commits merged into
2 commits merged into
Conversation
8b0163b to
d3bd8ea
Compare
mhegazy
reviewed
Nov 9, 2017
| YieldKeyword, | ||
| // Contextual keywords | ||
| AbstractKeyword, | ||
| /* @internal */ FirstContextualKeyword = AbstractKeyword, |
Contributor
There was a problem hiding this comment.
we keep them all at the bottom..
mhegazy
reviewed
Nov 9, 2017
| return moduleSpecifierToValidIdentifier(removeFileExtension(getBaseFileName(moduleSymbol.name))); | ||
| } | ||
|
|
||
| function moduleSpecifierToValidIdentifier(moduleSpecifier: string): string { |
Contributor
There was a problem hiding this comment.
pass in the compilerOptions, and use the target when calling isIdentifierStart
mhegazy
reviewed
Nov 9, 2017
| if (isValid) { | ||
| let char = String.fromCharCode(ch); | ||
| if (!lastCharWasValid) { | ||
| char = char.toUpperCase(); |
mhegazy
approved these changes
Nov 9, 2017
Contributor
|
We also need to port this to release-2.6 |
ghost
pushed a commit
that referenced
this pull request
Nov 9, 2017
…ifier (#19875) * For import completion of default import, convert module name to identifier * Suggestions from code review
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19841