Allow applyCodeActionCommand to take an array#19870
Merged
2 commits merged intoNov 9, 2017
Merged
Conversation
b4cf1f7 to
8fc9b14
Compare
mhegazy
approved these changes
Nov 9, 2017
Contributor
|
we need to port this to release-2.6 |
amcasey
approved these changes
Nov 9, 2017
| project.getLanguageService().applyCodeActionCommand(file, command).then( | ||
| ({ successMessage }) => { output(/*success*/ true, successMessage); }, | ||
| result => { | ||
| output(/*success*/ true, isArray(result) ? result.map(res => res.successMessage).join("\n\n") : result.successMessage); |
Member
There was a problem hiding this comment.
I assume there's no need to use a platform-specific linebreak.
ghost
pushed a commit
that referenced
this pull request
Nov 9, 2017
* Allow applyCodeActionCommand to take an array * Use this.host.newLine
ghost
pushed a commit
that referenced
this pull request
Nov 9, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19844