Add new error message when class implements class#19797
Merged
DanielRosenwasser merged 2 commits intoDec 19, 2017
Merged
Conversation
mhegazy
reviewed
Nov 7, 2017
| "category": "Error", | ||
| "code": 2716 | ||
| }, | ||
| "Class '{0}' is declared to implement class '{1}'. Did you mean 'extends'?": { |
Contributor
There was a problem hiding this comment.
i would rather this stayed class '{0}' incorrectly implements class '{1}'. Did you mean 'extends'?
Contributor
Author
There was a problem hiding this comment.
I can make a quick change to that effect, I was just using the error message from the issue description.
540f322 to
02b8b5b
Compare
Contributor
Author
|
PR Updated to resolve merge conflicts. |
| "category": "Error", | ||
| "code": 2718 | ||
| }, | ||
| "Class '{0}' incorrectly implements class '{1}'. Did you mean 'extends'?": { |
Member
There was a problem hiding this comment.
I'd prefer if the phrasing was more a little more specific on what's being discussed. Maybe something more like:
Class '{0}' incorrectly implements class '{1}'. Did you mean to extend '{1}' and inherit its members as a subclass?
Thoughts @mhegazy?
RyanCavanaugh
approved these changes
Nov 18, 2017
Contributor
Author
|
@DanielRosenwasser @mhegazy Any remaining concerns with this PR? |
2fa256e to
472f087
Compare
Contributor
Author
|
@mhegazy @DanielRosenwasser Updated to resolve conflicts in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19793
Added new diagnostic message for when a class incorrectly implements another class. Also added that diagnostic to the
errorCodeslist for thefixClassIncorrectlyImplementsInterfaceCodeFix