Skip to content

Apply 'space-before-function-paren' tslint rule#19789

Closed
ghost wants to merge 1 commit into
masterfrom
space-before-function-paren
Closed

Apply 'space-before-function-paren' tslint rule#19789
ghost wants to merge 1 commit into
masterfrom
space-before-function-paren

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 7, 2017

No description provided.

Comment thread src/harness/loggedIO.ts
function createWrapper(record: T, replay: T): T {
// tslint:disable-next-line only-arrow-functions
return <any>(function () {
return <any>(function() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be done by the formatter. by default we add a space.. but we can remove it using insertSpaceAfterFunctionKeywordForAnonymousFunctions.. I do no think we should enable this if it conflicts with our default formatting rules.. it will be a struggle fighting against the editors all the time.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghost ghost closed this Nov 7, 2017
@ghost ghost deleted the space-before-function-paren branch November 7, 2017 17:46
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant