Seems good to me, though I don't know this part of the codebase at all. It certainly fixes the issue that was reported.

@NoelAbrahams can you give tomorrow's typescript@next a try, and let us know if u are still seeing issues?

@mhegazy, happy to do that. How do I do install typescript@next in Visual Studio 2017? I see some instructions for VS 2013 and 2015 here

@NoelAbrahams Unfortunately, we haven't kept that page (or that script) up to date for VS 2017.

I think the best approach would be to temporarily make a backup of C:\Program Files (x86)\Microsoft SDKs\TypeScript\2.6\tsserver.js and replace it with a copy of tsserver.js that you get from running npm install typescript@next in some throwaway folder. Wherever you decide to run the npm install, the correct file is at node_modules\typescript\lib\tsserver.js.

@uniqueiniquity, thanks for the tip (great name BTW 😄)

@mhegazy @sheetalkamat using the latest tsserver.js I'm no longer able to reproduce the bug. So that appears to be fixed.

I'm still having a problem with the language service with inter-project references. Basicaly, the links in _references.ts are not being refreshed when a referenced folder is deleted and regenerated.

Not sure if it's related to this issue.

I'll try to see if I can reproduce the bug "Cross-project references fail when a folder/referenced .d.ts file is deleted, until _references.ts is manually updated".