Split runner selection from test selection#19729
Merged
Merged
Conversation
mhegazy
reviewed
Nov 3, 2017
|
|
||
| if (testConfig.test && testConfig.test.length > 0) { | ||
| for (const option of testConfig.test) { | ||
| if (testConfig.runners && testConfig.runners.length > 0) { |
Contributor
There was a problem hiding this comment.
should probably use runners||test so that jake runtests t=rwc still works.
Member
Author
There was a problem hiding this comment.
Done; now the CI server won't break :P
Member
|
Does it work with runtests-parallel? What about |
sandersn
approved these changes
Nov 6, 2017
Member
sandersn
left a comment
There was a problem hiding this comment.
One suggestion: maybe t= should be the runner chooser and re= should be the regular expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
runner,runners, orruflag which controls the runner suites which are enabled, (rather than inferring it fromtest. This allows you to sayjake runtests test=skype ru=rwcand run specific individual tests. 😉