Support path completions inside node_modules#19692
Merged
4 commits merged intoNov 3, 2017
Merged
Conversation
sheetalkamat
reviewed
Nov 2, 2017
| } | ||
|
|
||
| if (compilerOptions.moduleResolution === ts.ModuleResolutionKind.NodeJs) { | ||
| forEachAncestorDirectory(currentDirectory, ancestor => { |
Member
There was a problem hiding this comment.
This shouldnt be from currentDirectory but from getDirectoryPath(scriptPath) isnt it ?
sheetalkamat
approved these changes
Nov 3, 2017
Member
|
Test where current directory and script path are different would be good to add |
sheetalkamat
reviewed
Nov 3, 2017
| // @Filename: /src/a.ts | ||
| ////import {} from "/*1*/"; | ||
| ////import {} from "x//*2*/"; | ||
|
|
Member
There was a problem hiding this comment.
also suggest adding file /src/folder/b.ts and then adding same import statements there for the lookup
sheetalkamat
approved these changes
Nov 3, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19121