For getCompletionsAtPosition, require a flag to provide completions with code actions#19687
For getCompletionsAtPosition, require a flag to provide completions with code actions#196877 commits merged into
Conversation
| * Optional prefix to apply to possible completions. | ||
| */ | ||
| prefix?: string; | ||
| includeCompletionsWithActions: boolean; |
There was a problem hiding this comment.
i would rather we be more specific about what the feature does today, and make it includeNonImportedDeclarations or something along these lines.
Also please add a comment explaining what it does
There was a problem hiding this comment.
How about includeExternalModuleExports?
|
since this is a breaking change, we should rev the API version. |
|
@mhegazy Good to go? |
|
Will add this flag to vs code for 1.18 |
This new flag will make auto import completions opt-in for TS 2.6.2. Adding it for furture proofing microsoft/TypeScript#19687
| * Optional prefix to apply to possible completions. | ||
| */ | ||
| prefix?: string; | ||
| includeExternalModuleExports: boolean; |
|
@amcasey can you take this one for a spin as well. |
|
Waiting for approval from @amcasey |
|
Please port to release-2.6 as well. |
…ith code actions (#19687) * For getCompletionsAtPosition, require a flag to provide completions with code actions * Change name * Increase API version * Update API baselines * Add comment * Update API baseline
| } | ||
|
|
||
| export interface GetCompletionsAtPositionOptions { | ||
| includeExternalModuleExports: boolean; |
There was a problem hiding this comment.
This name suggests we're going to have a separate opt-in for each kind of completion that might return an action. Is that the plan?
There was a problem hiding this comment.
I could not think of another feature that we would add, and thus did not have a frame of reference. We also got feedback form the VSCode team that they would like to be able to disable the feature altogether, and incidentally from customer reports later on.
No description provided.