Minor cleanups in pathCompletions.ts#19685
Merged
2 commits merged intoNov 3, 2017
Merged
Conversation
mhegazy
reviewed
Nov 3, 2017
| ): CompletionInfo | undefined { | ||
| if (isInReferenceComment(sourceFile, position)) { | ||
| return PathCompletions.getTripleSlashReferenceCompletion(sourceFile, position, compilerOptions, host); | ||
| const entries = PathCompletions.getTripleSlashReferenceCompletion(sourceFile, position, compilerOptions, host); |
Contributor
There was a problem hiding this comment.
not sure why is this better than what was there before?
Author
There was a problem hiding this comment.
Makes it so PathCompletions do less work related to CompletionInfo so it can focus on just getting the paths.
mhegazy
reviewed
Nov 3, 2017
| /* @internal */ | ||
| namespace ts.Completions.PathCompletions { | ||
| export function getStringLiteralCompletionEntriesFromModuleNames(node: StringLiteral, compilerOptions: CompilerOptions, host: LanguageServiceHost, typeChecker: TypeChecker): CompletionInfo { | ||
| export function getStringLiteralCompletionEntriesFromModuleNames(node: StringLiteral, compilerOptions: CompilerOptions, host: LanguageServiceHost, typeChecker: TypeChecker): CompletionEntry[] { |
Contributor
There was a problem hiding this comment.
if you gonna change the output, you should make getStringLiteralCompletionsFromModuleNames
mhegazy
approved these changes
Nov 3, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompletionInfotocompletions.ts.forEachAncestorDirectoryandfind