Properly indent JSXText on format document#19619
Merged
Merged
Conversation
mhegazy
reviewed
Oct 31, 2017
| //// ) | ||
| ////} | ||
|
|
||
| goTo.position(21); |
There was a problem hiding this comment.
Or just use verify.currentFileContentIs instead of textAtCaretIs.
ghost
approved these changes
Oct 31, 2017
| processNode(child, childContextNode, childStartLine, undecoratedChildStartLine, childIndentation.indentation, childIndentation.delta); | ||
|
|
||
| if (child.kind === SyntaxKind.JsxText) { | ||
| const range = { pos: child.getStart(), end: child.getEnd() }; |
There was a problem hiding this comment.
Object literal has no contextual type, this can lead to wierd errors. Use const range: TextRange or just include it inline.
ghost
reviewed
Oct 31, 2017
| verify.textAtCaretIs("hello"); | ||
| goTo.position(50); | ||
| verify.textAtCaretIs("goodbye"); | ||
| goTo.marker('0'); |
There was a problem hiding this comment.
I think this whole test would be simpler with verify.currentFileContentIs -- and you could just remove everything except the <div> from the file.
RyanCavanaugh
approved these changes
Oct 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, only the first line of a contiguous block of text within a JSX element properly respects indentation when the document is formatted; all others are unaffected. This change inserts whitespace as needed so that all other lines indent properly as well.