Fix the order of JSDocTag kinds#19589
Conversation
JSDocTypeLiteral should not be grouped with the JSDocTag kinds, so move it just before they start, instead of just after. This updates the LastJSDocNode and LastJSDocTagNode.
|
@weswigham @mhegazy I can't remember if shuffles in the SyntaxKind enum are OK to have as breaking changes, since this is a const enum. I think technically they are no worse than any other breaking change, but practically they might be more confusing. |
|
It would be nice if we had a way to declare that something is an enum value but not declare what number it is. Users shouldn't be depending on |
|
@Andy-MS we do, it's a normal enum instead of a const enum. But those are slower, so we don't use them. I remember @weswigham describing some shenanigans to ensure that we at least make a regular enum available in our API, but I don't remember how resilient those shenanigans are. |
We grep for |
JSDocTypeLiteral should not be grouped with the JSDocTag kinds, so move it just before they start, instead of just after. This updates the LastJSDocNode and LastJSDocTagNode.
Found in palantir/tslint#3414