Disable error sourcemaps during session test#19504
Merged
weswigham merged 2 commits intoOct 26, 2017
Merged
Conversation
Member
Author
|
Also now disabling source maps on exceptions during the |
mhegazy
approved these changes
Oct 26, 2017
RyanCavanaugh
approved these changes
Oct 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The session API test takes 3.3s on my machine - most of this time is spent sourcemapping errors (intentionally generated) which are just swallowed by a null logger (I suspect
source-mapdoesn't handle large files particularly elegantly - it spends a lot of time in a customquickSort). This change disables sourcemaps on errors for the duration of the test, bring the test duration down from 3.3s to under 300ms (it no longer appears in the top 200, and I didn't bother digging for the exact time).