Skip to content

Memoize test rule provider#19501

Merged
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:memoize-rules-provider
Oct 26, 2017
Merged

Memoize test rule provider#19501
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:memoize-rules-provider

Conversation

@weswigham
Copy link
Copy Markdown
Member

@weswigham weswigham commented Oct 26, 2017

Formatting rule provider construction had become the majority of the time spent on the extract symbol/function tests, and as it turns out it is completely reusable (the optional action param to modify the options was never used). This memoizes it, which removes ~3s from the runtime of each of extract symbols and extract function, bringing each's runtime down to 2s and 3s, respectively.

@weswigham weswigham requested review from amcasey and mhegazy October 26, 2017 19:31
@weswigham weswigham merged commit 940175e into microsoft:master Oct 26, 2017
@weswigham weswigham deleted the memoize-rules-provider branch October 26, 2017 20:01
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants