Support completion details for special JsDoc completions#19494
Merged
1 commit merged intoOct 26, 2017
Merged
Conversation
mhegazy
approved these changes
Oct 26, 2017
armanio123
approved these changes
Oct 26, 2017
ghost
pushed a commit
that referenced
this pull request
Oct 26, 2017
mhegazy
pushed a commit
that referenced
this pull request
Nov 2, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19442
Also, our public API specifies
getCompletionEntryDetailsas never returningundefined, but this seems unavoidable if we receive a name we didn't provide an entry for. Maybe we shouldDebug.failin that case instead of returningundefined?