Use a map for RWC read file lookups#19487
Merged
weswigham merged 1 commit intoOct 26, 2017
Merged
Conversation
mhegazy
approved these changes
Oct 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what really made our outlandishly large RWC project an outlier (now it takes less time than vscode!). Every time we went to "lookup" a file - be it for an
existsor aread, we would iterate over every file read in the project. Talk about accidentally quadratic! This cuts ~30s of cpu time out of the RWC tests on my machine from our worst test (bringing wall-clock run time down by another ten seconds).