Skip to content

Use a map for RWC read file lookups#19487

Merged
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:use-map-for-loggedio-lookup
Oct 26, 2017
Merged

Use a map for RWC read file lookups#19487
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:use-map-for-loggedio-lookup

Conversation

@weswigham
Copy link
Copy Markdown
Member

@weswigham weswigham commented Oct 26, 2017

This is what really made our outlandishly large RWC project an outlier (now it takes less time than vscode!). Every time we went to "lookup" a file - be it for an exists or a read, we would iterate over every file read in the project. Talk about accidentally quadratic! This cuts ~30s of cpu time out of the RWC tests on my machine from our worst test (bringing wall-clock run time down by another ten seconds).

@weswigham weswigham requested review from mhegazy and sandersn October 26, 2017 00:07
@weswigham weswigham merged commit 2a016fc into microsoft:master Oct 26, 2017
@weswigham weswigham deleted the use-map-for-loggedio-lookup branch October 26, 2017 00:44
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants