Use light test flag by default#19362
Merged
Merged
Conversation
DanielRosenwasser
approved these changes
Oct 20, 2017
| var testTimeout = process.env.timeout || defaultTestTimeout; | ||
| var tests = process.env.test || process.env.tests || process.env.t; | ||
| var light = process.env.light || false; | ||
| var light = process.env.light === undefined ? true : (process.env.light !== "false"); |
Member
There was a problem hiding this comment.
What about process.env.light === undefined || process.env.light !== "false"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI will still have the flag off, so we should still get the additional checks there; but this significantly reduces test runtime when running locally -
assertInvariantsdominates the runtime of many tests; especially those which include lib files, such as many jsx tests. Overall, this is ~25% savings in wall-clock time when running tests locally. This is likely fine since the invariant assertion rarely catches any bugs anymore, and it'll still be running on CI to catch things before they get merged.