fix completions for string literal types with template string (#19162)#19204
Merged
DanielRosenwasser merged 1 commit intoDec 19, 2017
Merged
Conversation
DanielRosenwasser
requested changes
Oct 16, 2017
| return PathCompletions.getStringLiteralCompletionEntriesFromModuleNames(<StringLiteral>node, compilerOptions, host, typeChecker); | ||
| } | ||
| else if (isEqualityExpression(node.parent)) { | ||
| // Get completions from the type of the switch expression |
Member
There was a problem hiding this comment.
Why is the comment here swapped around?
Contributor
|
@Kingwl can you fix the comments please? |
70dae96 to
f1904a9
Compare
Contributor
Author
|
@mhegazy fixed |
DanielRosenwasser
approved these changes
Dec 19, 2017
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19162