Fix 'any' and 'keyof any' in mapped types#19185
Merged
Merged
Conversation
mhegazy
approved these changes
Oct 14, 2017
Contributor
|
Breaking change note, before this change a mapped type on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some inconsistencies relating to
anyandkeyof anyas the constraint type in a mapped type.Specifically, the mapped types
{ [P in any]: T }and{ [P in keyof any]: T }both now yield a type corresponding to{ [x: string]: T }.Fixes #19152.