Eliminate special case for extracting from a binary operator chain#18831
Merged
Conversation
1) It assumed left-associativity and was, therefore, wrong for (e.g.) exponentiation. 2) Arguably, if a user selects `a + |b + c|`, they want to extract `b + c`, not `a + b + c`. Not being able to do so is surprising (and we may eventually want to allow it), but so is having the rest of the least-common subtree extracted. Fixes microsoft#18268
Member
|
Why not continue allowing it for associative operators like |
Member
Author
|
@DanielRosenwasser I think it would be great to support that, but I'd want it to extract the range I specified - not an expanded range. Do you want to file a suggestion to that effect? |
Member
Author
|
Offline, @DanielRosenwasser and I agreed that implementing the desired behavior is a separate issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a + |b + c|, they want to extractb + c, nota + b + c. Not being able to do so is surprising (and we may eventually want to allow it), but so is having the rest of the least-common subtree extracted.Fixes #18268