Skip to content

add error message test#18674

Merged
aozgaa merged 1 commit into
microsoft:masterfrom
aozgaa:dev/aozgaa/exceptionEvent
Oct 9, 2017
Merged

add error message test#18674
aozgaa merged 1 commit into
microsoft:masterfrom
aozgaa:dev/aozgaa/exceptionEvent

Conversation

@aozgaa
Copy link
Copy Markdown
Contributor

@aozgaa aozgaa commented Sep 22, 2017

No functional change, just tests a feature that appeared to be untested.

@weswigham, might there be a cleaner way to test that the response's message is populated when the handler throws an error?

@weswigham
Copy link
Copy Markdown
Member

Capturing the lastSent seems fine to me - or do you mean checking expects? In which case, what's there also seems fine, I suppose.

@aozgaa aozgaa merged commit 5faa739 into microsoft:master Oct 9, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants