Handle unixy paths in RWC tests#18585
Merged
Merged
Conversation
sandersn
approved these changes
Sep 20, 2017
Member
sandersn
left a comment
There was a problem hiding this comment.
should ts.combinePaths handle this case too?
Member
|
What I meant is: should |
Member
Author
|
@sandersn its current behavior seems very intentional, as there's an explicit check for it. We probably rely on this behavior somewhere? |
Member
|
Yeah, probably. I think the current fix is fine. I removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue @sandersn was seeing with rooted unix paths outputting in the wrong directory. The issue was that
combinePathsdrops the LHS operand when the RHS is rooted (which is not what was desired here) - this never happens with windows-captured baselines as the paths are preprocessed to remove the root (by replacing the colon).Fixes #18561