Only introduce return properties at the top level#18448
Merged
Conversation
|
@amcasey, |
...for shorthand property assignment names when collecting usages.
...correctly in a containing scope. It's not an issue because we'll just declare a corresponding type parameter on the extracted function and pass the original as a type argument. Fixes microsoft#18142
...not in nested functions.
8088503 to
e2d94a2
Compare
Member
Author
RyanCavanaugh
approved these changes
Sep 13, 2017
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 16, 2017
Only introduce return properties at the top level (cherry picked from commit 288a57c)
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 18, 2017
Only introduce return properties at the top level (cherry picked from commit 288a57c)
ghost
reviewed
Sep 18, 2017
| return { body: createBlock(body.statements, /*multLine*/ true), returnValueProperty: undefined }; | ||
| } | ||
| let returnValueProperty: string; | ||
| let ignoreReturns = false; |
There was a problem hiding this comment.
This would be simpler to just have visitor take a parameter, is there a performance concern?
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 20, 2017
Only introduce return properties at the top level (cherry picked from commit 288a57c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...not in nested functions.
Fixes https://developercommunity.visualstudio.com/content/problem/111909/scenario-17-typescript-25-extract-method-cannot-co.html.