Add debugName property to Rule#18289
Merged
1 commit merged intoSep 6, 2017
Merged
Conversation
mhegazy
approved these changes
Sep 6, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps when stepping through the formatter and seeing an unknown rule applied; this tells us what property name it was assigned to in
rules.ts.This replaces
Rules#getRuleNamewhich wasn't very convenient to access while debugging; it's easier if the rule itself has all the information needed. Removed some unused methods fromrulesProviderthat used that.Also removed
toString()which isn't used anywhere and isn't any more useful than a normal debug inspection.