Handle indexed access types in getSymbolAtLocation and findAllReferences#18149
Conversation
sandersn
reviewed
Aug 30, 2017
| return isIndexedAccessTypeNode(node.parent.parent) ? getTypeFromTypeNode(node.parent.parent.objectType) : undefined; | ||
| } | ||
| })(); | ||
| return objectType && getPropertyOfType(objectType, escapeLeadingUnderscores((node as StringLiteral | NumericLiteral).text)); |
Member
There was a problem hiding this comment.
Can you construct a test case where the lack of escapeLeadingUnderscores makes a string literal element access fail? It would be something like x["__foo"], right?
Author
There was a problem hiding this comment.
Turns out I needed to update a few baselines related to this anyway.
sandersn
reviewed
Aug 30, 2017
| return getPropertyOfType(objectType, (<NumericLiteral>node).text as __String); | ||
| } | ||
| break; | ||
| const objectType = (() => { |
Member
There was a problem hiding this comment.
the IIFE seems like overkill for what could be let objectType; switch ... with some assignments to objectType inside. Or does it introduce some names that conflict with the outside scope?
sandersn
approved these changes
Aug 30, 2017
Member
sandersn
left a comment
There was a problem hiding this comment.
It's much easier to read with the new commit.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of #17787 which I accidentally merged.