Allow undefined/null to override any compiler option#18058
Merged
weswigham merged 1 commit intoSep 7, 2017
Conversation
Contributor
|
@weswigham does this also address #17617? |
Member
Author
|
@mhegazy It should, since |
mhegazy
approved these changes
Sep 6, 2017
|
This PR breaks |
Member
Author
|
@Andy-MS toPath was mostly just being used to get a canonical joined path for the new base path. If the canonicalization is an issue, I can adjust it to not canonicalize, as I do not believe it to be critical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the resulting js object, the value for either
nullorundefinedis alwaysundefined(nullis allowed in the json file, sinceundefinedis not; however this avoids dealing withnullwithin the compiler), and we no longer issue any errors on seeing either value while validating a config. Except"extends", since that's not really a compiler option and can't meaningfully be "overwritten".Also fixes path handling in extended configs to be relative to the including file, as was in the original feature and implementation. This must have silently regressed at some point, as there were configs which should have tested this still present; but no tests using them. This is a bugfix, but may constitute a breaking change from the prior release, depending on how long the bug has been present. But hey, nobody complained when it changed the first time, so nobody's likely to complain when it changes back, right?
Fixes #14184