Conversation
weswigham
approved these changes
Aug 25, 2017
Member
weswigham
left a comment
There was a problem hiding this comment.
Seems fine, one comment, but it's not really important.
|
|
||
| function getTypeReferenceSerializationKind(typeName: EntityName, location?: Node): TypeReferenceSerializationKind { | ||
| // ensure both `typeName` and `location` are parse tree nodes. | ||
| typeName = getParseTreeNode(typeName, isEntityName); |
Member
There was a problem hiding this comment.
This seems needlessly conservative - resolveEntityName does not use parent pointers on the name argument if location is present - it just draws the names to lookup from it. I don't think it strictly needs to be a parse tree node (and more importantly, couldn't a transform morph one name into another? Shouldn't that be resolved, so the serialized kind also reflects the transformation?)?
Probably too much of an edge case to care about until someone asks for it, anyway.
Contributor
Author
There was a problem hiding this comment.
I'd rather guard against it in any event.
Contributor
Author
|
This has also been ported to release-2.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17551