Conversation
sandersn
requested changes
Aug 24, 2017
Member
sandersn
left a comment
There was a problem hiding this comment.
I can't tell if there are relevant tests with this change. The code itself looks good.
|
|
||
|
|
||
| //// [output.js] | ||
| var _this = this; |
Member
There was a problem hiding this comment.
which tests were incorrect before this change? This is the closest one that I've found.
sandersn
approved these changes
Aug 24, 2017
Member
sandersn
left a comment
There was a problem hiding this comment.
Approved after the test from the bug is added.
Contributor
Author
|
This has been ported to release-2.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change switches the TypeScript class wrapper IIFE created by the ts transformer to use an arrow function rather than a function expression. This allows the es2015 transform to accurately determine whether it should capture
thisas_thisin the correct places.Fixes #16924