Remove template strings in checker.ts#18016
Conversation
|
did you file an issue for the chrome ? |
|
I think there was one already, but the bug tracker is down right now. |
sandersn
left a comment
There was a problem hiding this comment.
Given that the bug has been sitting on Chrome for 9+ months and that you can't hover variable values without it being fixed, I'd say this change is worthwhile.
| } | ||
| } | ||
|
|
||
| function enquote(s: string): string { |
There was a problem hiding this comment.
quote is a fine name in my opinion. It's not ambiguous in our codebase and English verbs nouns without a required prefix*.
*Usually.
There was a problem hiding this comment.
I'm not sure two uses justifies the existence of this function actually. Your call.
|
The chrome issue is actually likely an issue with the code mirror grammar they use for JS/TS. (Which, as an aside, probably needs to be updated for newer TS syntax) |
In the chrome debugger, the presence of a template string causes the rest of the document to be highlighted in red.
These aren't providing a lot of value vs string concatenation, so it seems easier to just remove them.