Skip to content

Remove debug assertions due to invalid syntax in generators transform#17879

Merged
rbuckton merged 1 commit into
masterfrom
fix17875
Aug 22, 2017
Merged

Remove debug assertions due to invalid syntax in generators transform#17879
rbuckton merged 1 commit into
masterfrom
fix17875

Conversation

@rbuckton
Copy link
Copy Markdown
Contributor

This removes the debug assertions in the generators transform that occur when we are unable to find an associated target for a break or continue statement. These resulted in debug assertions when we should be reporting syntax errors.

Fixes #17875

@rbuckton rbuckton merged commit a6015e9 into master Aug 22, 2017
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Aug 24, 2017

We need to port this to release-2.5

@rbuckton
Copy link
Copy Markdown
Contributor Author

This is now in release-2.5

@rbuckton rbuckton deleted the fix17875 branch August 24, 2017 18:06
@rbuckton rbuckton restored the fix17875 branch August 24, 2017 18:11
@mhegazy mhegazy deleted the fix17875 branch August 24, 2017 18:27
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants