Use NodeFlags to detect nodes inside with statements instead of climbing ancestors#17721
Merged
3 commits merged intoOct 23, 2017
Merged
Use NodeFlags to detect nodes inside with statements instead of climbing ancestors#177213 commits merged into
3 commits merged into
Conversation
This was referenced Aug 16, 2017
Author
|
@rbuckton Any comments? |
Author
|
@rbuckton Good to go? |
Author
|
@rbuckton Bump |
rbuckton
approved these changes
Oct 23, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, every time we needed to know whether a node was in a with statement, we would climb all of its ancestor nodes looking for a with statement. Since there usually wasn't one, this would take a while.
Now we just add a
NodeFlagsfor this during parsing. This is similar to the optimization done to detect whether we're in JSDoc. (#17176 (comment))This appears to give a 1% average improvement in performance in the checker, without any major slowdown in the parser.
Monaco - node (v8.2.1, x64)
Monaco - tsc (x86)
TFS - node (v8.2.1, x64)
TFS - tsc (x86)