Lower RWC Harness Memory Overhead#17692
Merged
Merged
Conversation
rbuckton
suggested changes
Aug 9, 2017
|
|
||
| let firstLine = true; | ||
| function newLine() { | ||
| return firstLine ? (firstLine = false, "") : "\r\n"; |
Contributor
There was a problem hiding this comment.
I'd rather just see an if here.
Member
Author
|
@rbuckton done |
rbuckton
approved these changes
Aug 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a bit. Swaps to using string concatenation instead of
array.joinfor baseline creation, and moves RWC declaration checking to the final step, and factors making the compilation context out of starting the compilation, so the original compilation can be disposed before the new compilation is started (and then moves to testing the declarations last so that it can be disposed).