Fix find-all-references for destructured getter#17483
Merged
3 commits merged intoAug 2, 2017
Merged
Conversation
6541d04 to
5d8cea4
Compare
|
|
||
| const typeOfPattern = checker.getTypeAtLocation(bindingElement.parent); | ||
| const propSymbol = typeOfPattern && checker.getPropertyOfType(typeOfPattern, (<Identifier>bindingElement.name).text); | ||
| if (propSymbol && propSymbol.flags & SymbolFlags.GetAccessor) { |
Member
There was a problem hiding this comment.
Should check both Get and Set assessors as the below sample is not error?
class test1 {
set x(a: number) {
}
}
const { x } = new test1();
Author
There was a problem hiding this comment.
Good catch! I didn't realize that was possible.
sheetalkamat
approved these changes
Jul 31, 2017
|
|
||
| const typeOfPattern = checker.getTypeAtLocation(bindingElement.parent); | ||
| const propSymbol = typeOfPattern && checker.getPropertyOfType(typeOfPattern, (<Identifier>bindingElement.name).text); | ||
| if (propSymbol && propSymbol.flags & (SymbolFlags.GetAccessor | SymbolFlags.SetAccessor)) { |
Member
There was a problem hiding this comment.
Nit: just use SymbolFlags.Accessor
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16922