Types Map #17468
Merged
Merged
Conversation
Member
Author
rbuckton
suggested changes
Aug 8, 2017
| } | ||
|
|
||
| private loadTypesMap() { | ||
| if (!this.host.fileExists(this.typesMapLocation)) { |
Contributor
There was a problem hiding this comment.
this.host.readFile method should return undefined if the file doesn't exist, allowing you to avoid an extra file system stat.
| return; | ||
| } | ||
| try { | ||
| const raw: TypesMapFile = JSON.parse(this.host.readFile(this.typesMapLocation)); |
Contributor
There was a problem hiding this comment.
Would it be worth using ts.parseJsonText and ts.convertToObject instead of JSON.parse so that we can get accurate line/column information for invalid JSON in the logs?
Contributor
There was a problem hiding this comment.
Ah, nevermind. I just saw that you want to port this to 2.3, which doesn't have these two methods.
Contributor
|
Can you resolve the merge conflict as well? |
Member
Author
|
@rbuckton Done + done |
rbuckton
approved these changes
Aug 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16685