Allow JSXAttribute to be IdentifierName#17466
Merged
weswigham merged 3 commits intoJul 31, 2017
Merged
Conversation
Member
|
@RyanCavanaugh might be a good candidate to take a look at this if he gets the chane. |
DanielRosenwasser
requested changes
Jul 27, 2017
Member
There was a problem hiding this comment.
You have an isIdentifierName, so would it be more appropriate to insert the check in that function?
I'm not saying that's the correct check, but either it belongs in that function or the PR title needs to be adjusted. I suspect it's the latter, and you can dismiss this review. I'll admit I'm just being pedantic. 😄
Member
|
👍 other than my comment. |
Member
Author
|
You are absolutely correct. I've added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17452
This change makes it so that we do not report strict mode identifier-name errors on jsx attributes.