createMissingNode: Only assign '.text' or '.escapedText' on nodes of the correct type#17439
Merged
2 commits merged intoJul 27, 2017
Merged
createMissingNode: Only assign '.text' or '.escapedText' on nodes of the correct type#174392 commits merged into
2 commits merged into
Conversation
942b9e8 to
cfddbbc
Compare
weswigham
reviewed
Jul 26, 2017
| case SyntaxKind.Identifier: | ||
| (result as Identifier).escapedText = "" as __String; | ||
| break; | ||
| default: // TODO: GH#17346 |
Member
There was a problem hiding this comment.
To preserve the intent of current behaviors, why not just replace the switch with
if (kind === SyntaxKind.Identifier) {
(result as Identifier).escapedText = "" as __String;
}
else if (isLiteralKind(kind)) {
(result as LiteralLikeNode).text = "";
}
?
This would also preserve the behavior when createMissingNode is called via parseExpected, or other indirect calls. We could also add some overloads for specific syntax kinds to avoid the need for casts.
ff9cf9b to
08afce6
Compare
weswigham
approved these changes
Jul 27, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17346