Skip to content

Change isStartOfParameter to be more general#17431

Merged
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:generalize-jsdoc-parameter-start-support
Jul 26, 2017
Merged

Change isStartOfParameter to be more general#17431
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:generalize-jsdoc-parameter-start-support

Conversation

@weswigham
Copy link
Copy Markdown
Member

@sandersn said he wanted to do this while updating our jsdoc parser, but kept running into infinite loops in the parser. With the general fix to that issue applied in #17420, isStartOfParameter can now be less ad-hoc and express its intent better, by using isStartOfType in full.

This changes our parser errors (and thereby our emit) on a pair of bad-parse baselines, arguably for the better (since the kinda-parameter lists actually get parsed as such now, rather than as parenthesized expressions).

@weswigham weswigham merged commit b9fe996 into microsoft:master Jul 26, 2017
@weswigham weswigham deleted the generalize-jsdoc-parameter-start-support branch July 26, 2017 22:21
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants