Actually let you disable colors with jake#17414
Merged
Merged
Conversation
ghost
reviewed
Jul 25, 2017
| } | ||
|
|
||
| var colors = process.env.colors || process.env.color || true; | ||
| var colors = boolLookup[process.env.colors] !== undefined ? boolLookup[process.env.colors] : boolLookup[process.env.color] !== undefined ? boolLookup[process.env.color] : true; |
There was a problem hiding this comment.
Could this just be:
var colorsFlag = process.env.color || process.env.colors;
var colors = colorsFlag !== "false" && colorsFlag !== "0";
ghost
approved these changes
Jul 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jake runtests colors=falseran tests with color. This was (super) noticable in our RWC logs.The
Gulpefileuses minimist for argument parsing and handles the flag correctly oncolors(just not its aliases, which are not coerced - but that's a minimist issue), so does not need a change.