Convert Array to ReadonlyArray/Push in commandLineParser.ts#17323
Merged
1 commit merged intoJul 21, 2017
Merged
Conversation
weswigham
approved these changes
Jul 21, 2017
Member
weswigham
left a comment
There was a problem hiding this comment.
I think this is good. It's good from a privilege perspective, anyway. I don't think this affects our API negatively, unless something flows out of these function which I'm not seeing.
Contributor
|
Definitely makes it easier to read and follow the logic. Thanks for that! |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.