Fix exceptions on empty tuple errors#17311
Merged
Merged
Conversation
Merged
Member
Author
|
I don't know how to restart the |
sandersn
approved these changes
Jul 20, 2017
Member
sandersn
left a comment
There was a problem hiding this comment.
Approved with one not to fix.
| @@ -2623,8 +2623,9 @@ namespace ts { | |||
| } | |||
| if (!context.encounteredError && !(context.flags & NodeBuilderFlags.AllowEmptyTuple)) { | |||
Member
There was a problem hiding this comment.
Invert the predicate here to make it more readable and put return undefined at the end.
Member
|
One NIT to fix. Also, I think that Jenkins might respond to commands in comments, if you know who to @ and you have permissions and you know the command. |
|
Thanks for the fix! I see it was merged to master, but I still experience this on latest version of Typescript (2.4.2) that I installed via npm. When can we expect it to be updated in NPM? |
This was referenced Aug 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17266
Fixes #17303
Our type to string function expected the node builder to always yield a type when errors were ignored, when for empty tuples it still wasn't returning nodes for an empty tuple type. Now it does.