Skip to content

JsTyping: Remove "safeList" global variable#17304

Merged
1 commit merged into
masterfrom
safeList
Jul 27, 2017
Merged

JsTyping: Remove "safeList" global variable#17304
1 commit merged into
masterfrom
safeList

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 19, 2017

This code used a "safeList" global variable to cache the result of loading the safe list.
This has the unintuitive behavior that the value of the safeListPath parameter isn't observed after the first time discoverTypings is called.
Instead, we require the caller of discoverTypings to pass in the safe list itself instead of a path, and require the caller to handle caching of the safe list.

There is also a private static safelist in editorServices.ts that looks suspicious, but I'll leave that for later.

Copy link
Copy Markdown
Member

@minestarks minestarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost ghost merged commit 3330f2a into master Jul 27, 2017
@ghost ghost deleted the safeList branch July 27, 2017 17:54
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants