Make NodeArray readonly#17213
Merged
4 commits merged intoJul 18, 2017
Merged
Conversation
weswigham
approved these changes
Jul 18, 2017
Member
weswigham
left a comment
There was a problem hiding this comment.
Generally seems like it adds safety. I dislike the cast into the mutating function for what amounts to an immutable usage, but I suppose a copy of the function that returns a slice rather than doing an unshift is a bit much.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't modify a node after it has been created. There is one place where we must cast to
as MutableNodeArrayines2015.ts; this is on a node that we just created.