MultistepOperation: Don't need 'completed', just use requestId === undefined#17173
Conversation
rbuckton
suggested changes
Aug 8, 2017
| this.operationHost.sendRequestCompletedEvent(this.requestId); | ||
| } | ||
| this.completed = true; | ||
| if (this.requestId) { |
Contributor
There was a problem hiding this comment.
Is it possible for a request to have an id of 0? It might be more reliable to test this.requestId !== undefined
Author
There was a problem hiding this comment.
It looks like the server is responsible for sending us these IDs, so it might have happened to always be non-zero when coming from VSCode, but best not to rely on that.
Contributor
|
Can you resolve the merge conflict and the comment above? |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
!this.completed,this.requestIdshould always be set. And there's no need to leaverequestIdset if the request is completed. So we can combine these into one variable.