Enable "object-literal-shorthand" lint rule#16987
Merged
1 commit merged intoJul 7, 2017
Merged
Conversation
1a4a1a8 to
962b70e
Compare
alfaproject
reviewed
Jul 7, 2017
| resolvePath: function(path: string): string { | ||
| return _path.resolve(path); | ||
| }, | ||
| resolvePath: path => _path.resolve(path), |
Member
There was a problem hiding this comment.
👎 - that's a possible behavioral change in multiple ways (different this reference, different behavior when more than one argument is supplied). Very dangerous if someone is currently calling e.g. [a, b].map(sys.resolvePath), it will throw an exception where one wasn't before.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
{ foo: foo }with{ foo }and{ foo: function() {} }with{ foo() {} }.